[Executorch] Update EXECUTORCH_LIBRARY macro #5602

kimishpatel · 2024-09-24T19:25:06Z

Stack from ghstack (oldest at bottom):

Change it to generate unique static variable name. Otherwise we cant register
two ops from the same file.

Also dont know what happens when two files have the same static variable.
Probably nothing unless you are trying to refer to it from some other file.

Differential Revision: D62623240

Change it to generate unique static variable name. Otherwise we cant register two ops from the same file. Also dont know what happens when two files have the same static variable. Probably nothing unless you are trying to refer to it from some other file. Differential Revision: [D62623240](https://our.internmc.facebook.com/intern/diff/D62623240/) [ghstack-poisoned]

pytorch-bot · 2024-09-24T19:25:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5602

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures

As of commit 61be4c0 with merge base b2517d6 ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
Lint / lintrunner / linux-job (gh)
>>> Lint for kernels/quantized/test/test_quant_dequant_per_token.py:
pull / test-custom-ops-linux (buck2) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-custom-ops-linux (cmake) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-linux (bf16, buck2, portable) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-linux (bf16, cmake, portable) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-linux (fp32, buck2, portable) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-linux (fp32, buck2, xnnpack+custom) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-linux (fp32, buck2, xnnpack+custom+qe) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-linux (fp32, cmake, portable) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-linux (fp32, cmake, xnnpack+custom) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-linux (fp32, cmake, xnnpack+custom+qe) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llama-runner-qnn-linux (fp32, cmake, qnn) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-llava-runner-linux / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-models-linux (buck2, mv3, portable, linux.2xlarge, 90) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-models-linux (cmake, mv3, portable, linux.2xlarge, 90) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-models-linux (cmake, vit, xnnpack-delegation, linux.2xlarge, 90) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-pybind-build-linux (cmake) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-quantized-aot-lib-linux (cmake) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-selective-build-linux (buck2) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / test-selective-build-linux (cmake) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / unittest / linux / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
pull / unittest / macos / macos-job (gh)
/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long long' in initializer list [-Wc++11-narrowing]
pull / unittest-arm (buck2) / linux-job (gh)
/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-09-24T19:25:35Z

This pull request was exported from Phabricator. Differential Revision: D62623240

Change it to generate unique static variable name. Otherwise we cant register two ops from the same file. Also dont know what happens when two files have the same static variable. Probably nothing unless you are trying to refer to it from some other file. Differential Revision: [D62623240](https://our.internmc.facebook.com/intern/diff/D62623240/) ghstack-source-id: 244449206 Pull Request resolved: pytorch/executorch#5602

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2024

facebook-github-bot added the fb-exported label Sep 24, 2024

kimishpatel closed this Oct 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Executorch] Update EXECUTORCH_LIBRARY macro #5602

[Executorch] Update EXECUTORCH_LIBRARY macro #5602

Uh oh!

kimishpatel commented Sep 24, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 24, 2024 •

edited

Loading

Uh oh!

facebook-github-bot commented Sep 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Executorch] Update EXECUTORCH_LIBRARY macro #5602

[Executorch] Update EXECUTORCH_LIBRARY macro #5602

Uh oh!

Conversation

kimishpatel commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5602

❌ 27 New Failures

Uh oh!

facebook-github-bot commented Sep 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kimishpatel commented Sep 24, 2024 •

edited

Loading

pytorch-bot bot commented Sep 24, 2024 •

edited

Loading